-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert exec command for 3.4.0 release #526
Conversation
Sorry about that folks, that's my fault. I didn't test this on Windows at
all. I'll get a VM set up this weekend and give it a shot.
…On Thu, Sep 12, 2019 at 3:45 PM Adrian Utrilla ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#526>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHHGH4CX623IGNSUADBMMTQJKL4BANCNFSM4IWITDNQ>
.
--
omar
M.S., GSE, MDMA, OSCP, OSCE, OSWP, CISSP, GSEC (Pink), KARATE (Black Belt),
GCCC (Gold),
GPEN, GWAPT, GCIH, Hats, GCED, 6-APB, GCPM, Adobe Photoshop, CCNA, CEH,
ECSA, PEE, CNDA, A+, Network+, Cyber+, Cyber++, Instagram
*BE INFORMED. BE STRATEGIC. BE SECURE.*
Please consider the environment before printing this email
|
@ancat No worries! We should've caught that in code review. That would be awesome! As well though, imo feel free to just make the command linux and osx exclusive and just provide an "Unsupported on Windows" message for windows. |
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
13 similar comments
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 36.46% 36.46%
=======================================
Files 20 20
Lines 2863 2863
=======================================
Hits 1044 1044
Misses 1725 1725
Partials 94 94 Continue to review full report at Codecov.
|
Building the
exec.go
subcommand is failing on the windows build. Backing this out frommaster
so that we can release3.4.0
cc @ancat