Make check whether file contains invalid keys for encryption dependent on output store #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devstein
approved these changes
Dec 29, 2023
| // HasSopsTopLevelKey returns true if the given branch has a top-level key called "sops". | ||
| func HasSopsTopLevelKey(branch sops.TreeBranch) bool { | ||
| for _, b := range branch { | ||
| if b.Key == "sops" { |
There was a problem hiding this comment.
Not worth it for this PR, but thoughts on adding a constant for "sops"?
https://github.com/search?q=repo:getsops/sops+sops%22+language:Go&type=code
There was a problem hiding this comment.
Yeah, that would be a very good idea!
…t on output store. Signed-off-by: Felix Fontein <[email protected]>
felixfontein
force-pushed
the
encrypted-check
branch
from
8d6d70e
to
1bda828
Compare
|
@devstein thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the output store, the keys used for storing SOPS metadata vary. For YAML, JSON, and INI files, the
sopstop-level key is used. For DotEnv files, keys starting withsops_are used.Fixes #1384.