Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag releases with v prefix #540

Closed
carlpett opened this issue Sep 26, 2019 · 3 comments
Closed

Tag releases with v prefix #540

carlpett opened this issue Sep 26, 2019 · 3 comments
Assignees
Labels
enhancement priority/low Low priority issues

Comments

@carlpett
Copy link
Contributor

For importing sops as a Go module in other code, the release tags should be prefixed with a v, eg v3.4.0 rather than 3.4.0.

See https://github.com/golang/go/wiki/Modules#modules (emphasis mine):

Modules must be semantically versioned according to semver, usually in the form v(major).(minor).(patch), such as v0.1.0, v1.2.3, or v1.5.0-rc.1. The leading v is required. If using Git, tag released commits with their versions.

If this sounds acceptable, could you also add a v3.4.0 tag "on top" of 3.4.0?

@autrilla
Copy link
Contributor

autrilla commented Oct 8, 2019

I pushed the v3.4.0 tag for now, and I guess we'll need to push an additional v tag every release, or stop pushing non-v tags.

@ajvb ajvb self-assigned this Oct 8, 2019
@ajvb
Copy link
Contributor

ajvb commented Oct 8, 2019

Thanks @autrilla - I can come back to this before the next release and update the travis config and such to support it.

@davidovich
Copy link

I believe this can be closed by #566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority/low Low priority issues
Projects
None yet
Development

No branches or pull requests

4 participants