feat: Remove default mapping of "transaction" topic to "events" #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.30% // Head: 92.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3250 +/- ##
==========================================
+ Coverage 92.30% 92.31% +0.01%
==========================================
Files 697 697
Lines 31630 31655 +25
==========================================
+ Hits 29195 29223 +28
+ Misses 2435 2432 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
evanh
approved these changes
Oct 13, 2022
lynnagara
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 13, 2022
Should be (roughly) synchronized with equivalent change in Snuba (getsentry/snuba#3250) This would only affect self hosted and dev users who are using the Kafka backend. All Sentry prod envivonments have already been migrated via other methods to ensure zero downtime during the transition.
All ST customers were migrated a few weeks ago and are already running with these same overrides in their settings. |
This was referenced Oct 17, 2022
enochtangg
pushed a commit
that referenced
this pull request
Oct 17, 2022
Should be (roughly) synchronized with getsentry/sentry#39988 which will send events to the new topic. This would only affect self hosted and dev users who are using the Kafka backend. All Sentry prod environments have already been migrated via other methods to ensure zero downtime during the transition.
barkbarkimashark
pushed a commit
to getsentry/sentry
that referenced
this pull request
Oct 18, 2022
Should be (roughly) synchronized with equivalent change in Snuba (getsentry/snuba#3250) This would only affect self hosted and dev users who are using the Kafka backend. All Sentry prod envivonments have already been migrated via other methods to ensure zero downtime during the transition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be (roughly) synchronized with getsentry/sentry#39988 which will send events to the new topic.
This would only affect self hosted and dev users who are using the Kafka backend. All Sentry prod environments have already been migrated via other methods to ensure zero downtime during the transition.