chore(scm): metrics for derive_code_mappings #81329
Merged
+90
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathteng
commented
Nov 26, 2024
| ) | ||
|
|
||
| def test_does_not_raise_installation_removed(self): | ||
| def test_does_not_raise_installation_removed(self, mock_record): |
There was a problem hiding this comment.
this test wasn't testing anything because the platform "any" was not in the list of SUPPORTED_LANGUAGES. fixed that above
iamrajjoshi
approved these changes
Nov 26, 2024
| try: | ||
| with lock.acquire(): | ||
| # This method is specific to the GithubIntegration | ||
| if not isinstance(installation, GitHubIntegration): |
GabeVillalobos
approved these changes
Nov 26, 2024
Comment on lines
+58
to
+62
| return self.respond( | ||
| { | ||
| "text": f"The {installation.model.provider} integration does not support derived code mappings" | ||
| }, | ||
| status=status.HTTP_400_BAD_REQUEST, |
There was a problem hiding this comment.
Should we ever hit this case? If so, do we want to log here?
There was a problem hiding this comment.
no, the query for the installation only filters for github integrations. this fixes the typing but i need to return early and return something
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81329 +/- ##
===========================================
+ Coverage 52.90% 80.35% +27.45%
===========================================
Files 7195 7220 +25
Lines 318237 319588 +1351
Branches 20772 20772
===========================================
+ Hits 168369 256814 +88445
+ Misses 149475 62381 -87094
Partials 393 393 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SLO tracking for the
derive_code_mappingstask, which is currently only used for GitHub integrations.