Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Add chart unfurl support for EAP alerts #81184

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

shruthilayaj
Copy link
Member

This adds support for EAP spans dataset for chart unfurls for
span alert notifications

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 22, 2024
@shruthilayaj shruthilayaj marked this pull request as ready for review November 22, 2024 16:36
@shruthilayaj shruthilayaj requested a review from a team as a code owner November 22, 2024 16:36
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/incidents/logic.py 77.77% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #81184    +/-   ##
========================================
  Coverage   80.32%   80.33%            
========================================
  Files        7214     7215     +1     
  Lines      319316   319147   -169     
  Branches    20775    20712    -63     
========================================
- Hits       256504   256394   -110     
+ Misses      62418    62361    -57     
+ Partials      394      392     -2     

@shruthilayaj shruthilayaj merged commit f9a99cb into master Nov 25, 2024
49 of 50 checks passed
@shruthilayaj shruthilayaj deleted the feat/shruthi/add-chart-unfurls-eap-span-alerts branch November 25, 2024 14:12
harshithadurai pushed a commit that referenced this pull request Nov 25, 2024
This adds support for EAP spans dataset for chart unfurls for 
span alert notifications
evanh pushed a commit that referenced this pull request Nov 25, 2024
This adds support for EAP spans dataset for chart unfurls for 
span alert notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants