ref: fix num_comments typing in migrations again #75110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
commented
Jul 26, 2024
| @@ -73,7 +73,7 @@ def _bulk_retrieve_group_values(group_ids: list[int], Group: type[Group]) -> lis | |||
| status=group_values["status"], | |||
| substatus=group_values["substatus"], | |||
| first_seen=group_values["first_seen"], | |||
| num_comments=group_values["num_comments"], | |||
| num_comments=group_values["num_comments"] or 0, | |||
There was a problem hiding this comment.
the model requires int but the schema here is nullable
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75110 +/- ##
==========================================
- Coverage 78.10% 78.09% -0.01%
==========================================
Files 6755 6755
Lines 301462 301462
Branches 51861 51861
==========================================
- Hits 235445 235438 -7
- Misses 59686 59694 +8
+ Partials 6331 6330 -1 |
wedamija
approved these changes
Jul 27, 2024
IanWoodard
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.