Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(profiling): add deny list check when ingesting function metrics for a given project #69180

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Apr 18, 2024

No description provided.

@viglia viglia requested a review from a team as a code owner April 18, 2024 08:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.71%. Comparing base (34bf316) to head (0251b24).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #69180   +/-   ##
=======================================
  Coverage   79.71%   79.71%           
=======================================
  Files        6421     6421           
  Lines      285345   285345           
  Branches    49166    49166           
=======================================
+ Hits       227461   227462    +1     
+ Misses      57447    57446    -1     
  Partials      437      437           
Files Coverage Δ
src/sentry/profiles/task.py 57.91% <ø> (ø)

... and 8 files with indirect coverage changes

Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting a little complicated. Any thoughts on using a single allowed project ids option instead?

@viglia viglia merged commit a008f84 into master Apr 18, 2024
50 checks passed
@viglia viglia deleted the viglia/enhance/add-profile-metrics-deny-list-check branch April 18, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants