Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(search) case insensitive grammar #69146

Merged
merged 30 commits into from
Apr 18, 2024
Merged

ref(search) case insensitive grammar #69146

merged 30 commits into from
Apr 18, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Apr 17, 2024

Same love for the backend

JonasBa and others added 29 commits April 16, 2024 15:29
@JonasBa
ref(search): remove rawValue and value parsing from grammar
2f82625
@JonasBa
ref(search): remove number parsing
6117ab4
@JonasBa
ref(search): parse values
4601176
@getsantry
🛠️ apply eslint style fixes
1a2f8c4
@JonasBa
ref(search): parse values under separate obj
c2ab492
@JonasBa
ref(search): update grammar to parse numeric value
3dae3b4
@JonasBa
ref(search): update duration parsing
0bae1ef
@JonasBa
ref(search): remove unused prop
40feffd
@JonasBa
ref(search): dont parse if parse config is not set
2c3d9ba
@JonasBa
ref(search): case insensitive size units
29d0cf7
@JonasBa
ref(search): do the cheaper check first
74a6303
@JonasBa
ref(search): lowercase size before normalizing value
2ea61c3
@JonasBa
ref(search): consume unit
e9f2805
@JonasBa
ref(search): change grammar
f3b89e4
@JonasBa
ref(search): maybe this
1074618
@JonasBa
ref(search): use regexp
b92036f
@JonasBa
ref(search): remove blank lines
c5b6f67
@JonasBa
ref(search): revert case sensitivity changes
1ee36b8
@JonasBa
ref(search): revert case sensitivity changes
7dceb94
@JonasBa
ref(search): revert case sensitivity changes
1a08cbc
@JonasBa
ref(search): revert parse
f40a9eb
@JonasBa
ref(search): revert lowercase
a02dd2c
@JonasBa
ref(search): fix blank lines
028c21f
@JonasBa
ref(search): add value parsing
490c0c5
@JonasBa
ref(search): add parse tests
eb9ae7f
@JonasBa
ref(search): allow case insensitive units
fe9c392
@JonasBa @evanpurkhiser
Update static/app/components/searchSyntax/grammar.pegjs
bb906cb 
Co-authored-by: Evan Purkhiser <[email protected]>
@JonasBa
ref(search): allow case insensitive units
24b3b8b
@JonasBa
ref(search): allow case insensitive units
34373b4
@JonasBa JonasBa requested review from a team as code owners April 17, 2024 20:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 17, 2024
wedamija
wedamija approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should be equivalent. I have some vague memory of changes like this changing the structure that parsimonious uses, but if it breaks anything it should show up in tests

Base automatically changed from jb/search/case-sensitive-size-frontend to master April 17, 2024 21:30
@JonasBa JonasBa merged commit 01fdf2f into master Apr 18, 2024
48 checks passed
@JonasBa JonasBa deleted the jb/search/case-sensitive-size-backend branch April 18, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

@evanpurkhiser evanpurkhiser Awaiting requested review from evanpurkhiser

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonasBa @wedamija