ref(related_issues): Minor code refactoring before feature work #69137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes included: * Only return new data shape in endpoint * Add rate limit to endpoint * More explicit typing * Return list of group IDs instead of groups
armenzg
commented
Apr 17, 2024
| response: dict[str, Any] = { | ||
| related_set["type"]: [int(g.id) for g in related_set["data"]] | ||
| for related_set in related_issues | ||
| } |
There was a problem hiding this comment.
We won't be returning this data shape. The UI only uses the new shape (#68985).
| @@ -13,8 +11,8 @@ | |||
| } | |||
|
|
|||
|
|
|||
| def find_related_issues(group: Group) -> list[dict[str, Any]]: | |||
| related_issues = [] | |||
| def find_related_issues(group: Group) -> list[dict[str, list[int] | str]]: | |||
There was a problem hiding this comment.
A little tighter than Any.
| from sentry.models.group import Group | ||
| from sentry.utils.query import RangeQuerySetWrapper | ||
|
|
||
|
|
||
| def same_root_cause_analysis(group: Group) -> list[Group]: | ||
| def same_root_cause_analysis(group: Group) -> list[int]: |
There was a problem hiding this comment.
The endpoint is going to return the group IDs. This also makes typing a bit simpler in the module above.
vartec
approved these changes
Apr 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included: