-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Activated Alert Rules to alert rule index #69124
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
292129f
add activated alert rule row and fetch activated alerts
nhsiehgit 5edcf36
updated row status badge
nhsiehgit 5a8db4f
move alert badge next to status
nhsiehgit e72d775
remove link to alert details
nhsiehgit 3d54f15
updated icons
nhsiehgit aa40fdb
nits
nhsiehgit 902efd6
update stub fixture
nhsiehgit 4c830cd
update test
nhsiehgit b0449f3
expect renders activated rules
nhsiehgit 09c8c78
added test for activated status
nhsiehgit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
added test for activated status
- Loading branch information
commit 09c8c78674822ff59a66a9c9bb355032375a76ec
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: recommend decomposing each of the render calls. If you're accessing things like the
rule
it'd be extra cool to usereact-query
to avoid prop drilling too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm how does react-query addres prop drilling?
Or did you mean context?
for now i think i'll keep these patterns to match
rules.tsx
😅I'll create a follow up ticket to clean both of these up though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticket here: https://github.com/orgs/getsentry/projects/199/views/3?pane=issue&itemId=60130307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-query uses context to store api data for you. (it also handles automatic updates and syncing data across all uses of the "store").
for example, if you wanted to fetch a specific
rule
you could douseRule(ruleId)
-- then that hook uses the api react-query hook to fetch the data (which updates the value in the store for rule etc).If you haven't used it before.. it's kinda a mind meld and we should def wait until later to update. i'm planning on using it for the API requests with project settings pages, so we could also take a look at it when that comes up.