Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable queries using project slug as filter and groupby in Metrics API #69111

Merged
merged 24 commits into from
Apr 18, 2024
Merged

Enable queries using project slug as filter and groupby in Metrics API #69111

merged 24 commits into from
Apr 18, 2024

Conversation

shellmayr
Copy link
Member

Closes #68416

@shellmayr
Add visitor to replace project-filter by project-id-filter in query
956b9b3
@shellmayr
Add visitor to replace groupby:project by groupby:project_id
2fbf999
@shellmayr
wip: generalize
ab65551
@shellmayr
wip: implement first running version of modulator-visitor based on fl…
d53d659 
…exibly defined modulators
@shellmayr
add query post-processing steps
0518514
@shellmayr
wip: fix bugs & restructure
08caa89
@shellmayr
wip: everything works before cleanup
5034dbb
@shellmayr
wip: cleanup
164836f
@shellmayr
wip: remove ModulationMetadata - not needed
a8e14a1
@shellmayr
wip: move things around
7b830af
@shellmayr
wip: inject projects directly into the visitor that needs it instead …
bc5a402 
…of passing it around
@shellmayr
wip: move groupby modulation into function for ModulatorVisitor
2f9f9c8
@shellmayr
add tests & refactor
a8d757f
@shellmayr
wip: fix mypy errors
6a1e9e1
@shellmayr
add more tests & refactor
0a8142d
@shellmayr
remove comment
a414b9a
@shellmayr
refactor into optimized object structure to reduce shared state
008d7c6
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 17, 2024
iambriccardo
iambriccardo reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, this paves the way for a great extensible foundation for aliasing in the API.

Left some comments and some nits, after some of those are resolved, we are good to go.

src/sentry/sentry_metrics/querying/data/execution.py Show resolved Hide resolved
src/sentry/sentry_metrics/querying/data/api.py Outdated Show resolved Hide resolved
src/sentry/sentry_metrics/querying/data/mapping/mapper.py Show resolved Hide resolved
src/sentry/sentry_metrics/querying/data/postprocessing/remapping.py Outdated Show resolved Hide resolved
src/sentry/sentry_metrics/querying/visitors/base.py Outdated Show resolved Hide resolved
src/sentry/sentry_metrics/querying/visitors/query_expression.py Outdated Show resolved Hide resolved
src/sentry/sentry_metrics/querying/visitors/query_expression.py Outdated Show resolved Hide resolved
src/sentry/sentry_metrics/querying/visitors/query_expression.py Outdated Show resolved Hide resolved
src/sentry/sentry_metrics/querying/visitors/query_expression.py Show resolved Hide resolved
tests/sentry/sentry_metrics/querying/data/test_api.py Show resolved Hide resolved
@shellmayr shellmayr marked this pull request as ready for review April 18, 2024 12:09
@shellmayr shellmayr requested a review from a team as a code owner April 18, 2024 12:09
iambriccardo
iambriccardo approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

iambriccardo
iambriccardo approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shellmayr shellmayr enabled auto-merge (squash) April 18, 2024 12:14
@shellmayr shellmayr merged commit 7780004 into master Apr 18, 2024
49 checks passed
@shellmayr shellmayr deleted the shellmayr/feat/project-to-project-id-draft-2 branch April 18, 2024 12:39
@shellmayr shellmayr mentioned this pull request Apr 18, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement project <-> project_id transformation in the metrics API
2 participants
@shellmayr @iambriccardo