Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): Cleanup old session-replay-trace-table experiment (backend) #68822

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 12, 2024

Related to, but not depending on #68821 because the feature is already turned off

@ryan953 ryan953 requested a review from a team as a code owner April 12, 2024 19:28
@ryan953 ryan953 marked this pull request as draft April 12, 2024 19:29
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 12, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@ryan953 ryan953 changed the base branch from master to ryan953/cleanup-pref-table-experiment April 12, 2024 19:29
@ryan953 ryan953 force-pushed the ryan953/cleanup-pref-table-experiment-be branch from 800b9f4 to ea4014e Compare April 16, 2024 23:18
@ryan953 ryan953 changed the base branch from ryan953/cleanup-pref-table-experiment to master April 16, 2024 23:18
@ryan953 ryan953 marked this pull request as ready for review April 16, 2024 23:18
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.68%. Comparing base (2b9ba9d) to head (53385ce).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #68822      +/-   ##
==========================================
- Coverage   79.68%   79.68%   -0.01%     
==========================================
  Files        6429     6429              
  Lines      285303   285302       -1     
  Branches    49140    49140              
==========================================
- Hits       227341   227339       -2     
- Misses      57594    57595       +1     
  Partials      368      368              
Files Coverage Δ
src/sentry/conf/server.py 89.22% <ø> (ø)
src/sentry/features/temporary.py 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

@ryan953 ryan953 merged commit fe86a58 into master Apr 17, 2024
49 checks passed
@ryan953 ryan953 deleted the ryan953/cleanup-pref-table-experiment-be branch April 17, 2024 22:57
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants