Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(superuser): Add logs to check u2f #66393

Merged
merged 2 commits into from
Mar 6, 2024
Merged

chore(superuser): Add logs to check u2f #66393

merged 2 commits into from
Mar 6, 2024

Conversation

schew2381
Copy link
Member

No description provided.

@schew2381 schew2381 requested a review from a team March 6, 2024 01:51
@schew2381 schew2381 self-assigned this Mar 6, 2024
@schew2381 schew2381 requested review from a team as code owners March 6, 2024 01:51
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 6, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.29%. Comparing base (2020434) to head (0ec4259).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #66393      +/-   ##
==========================================
- Coverage   84.29%   84.29%   -0.01%     
==========================================
  Files        5309     5309              
  Lines      237211   237226      +15     
  Branches    41039    41039              
==========================================
+ Hits       199966   199978      +12     
- Misses      37026    37029       +3     
  Partials      219      219
Files Coverage Δ
src/sentry/api/endpoints/auth_index.py 83.09% <20.00%> (-1.69%) ⬇️

... and 21 files with indirect coverage changes

@schew2381 schew2381 merged commit 320c11b into master Mar 6, 2024
48 of 49 checks passed
@schew2381 schew2381 deleted the seiji/chore/check-superuser-u2f-with-logs branch March 6, 2024 17:07
aliu39 pushed a commit that referenced this pull request Mar 6, 2024
@schew2381 @aliu39
chore(superuser): Add logs to check u2f (#66393)
5007096
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nhsiehgit nhsiehgit nhsiehgit approved these changes

Assignees

@schew2381 schew2381

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schew2381 @nhsiehgit