Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: use internal pypi #38255

Merged
merged 1 commit into from
Sep 7, 2022
Merged

ref: use internal pypi #38255

merged 1 commit into from
Sep 7, 2022

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Aug 30, 2022 •
edited
Loading

this has a bunch of things:

  • speeds up setup-sentry by ~30-40 seconds
  • removes a bunch of hacks for M1 since everything is prebuilt now
  • avoids a whole class of failure modes with local development not having build deps set up properly
  • allows pip-compile to succeed on M1 without needing a bunch of dependencies
  • fully functional python setup on (macos (x86_64, arm64), linux (amd64, aarch64))
  • enables further installation optimizations with everything being a wheel
  • removes a bunch of unneeded apt dependencies

packages are sourced from https://github.com/getsentry/pypi

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 30, 2022
asottile-sentry
asottile-sentry commented Aug 31, 2022
View reviewed changes
.github/workflows/development-environment.yml
Comment on lines +66 to +68
# GHA pythons are miscompiled and report macos 10.16
env:
SYSTEM_VERSION_COMPAT: 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the pyenv pythons do not have this limitation and that our minimum supported macos version is 12.x

@asottile-sentry asottile-sentry mentioned this pull request Aug 31, 2022
Closed
@asottile-sentry asottile-sentry marked this pull request as ready for review September 1, 2022 13:12
@asottile-sentry asottile-sentry requested review from a team as code owners September 1, 2022 13:12
joshuarli
joshuarli approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's happening!!!!!!!!!!

lol wheelslam when

Obtaining file:https:///Users/josh/dev/sentry
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build wheel ... \

joshuarli
joshuarli reviewed Sep 1, 2022
View reviewed changes
docker/Dockerfile
# These are also installed last as they are needed
# during container run and can have the same deps w/
# build deps such as maxminddb.
&& apt-get install -y --no-install-recommends \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 can't wait for this in getsentry as well

@asottile-sentry asottile-sentry merged commit a06a3c5 into master Sep 7, 2022
@asottile-sentry asottile-sentry deleted the asottile-internal-pypi branch September 7, 2022 13:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshuarli joshuarli joshuarli approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asottile-sentry @joshuarli