Prefer the SENTRY_RELEASE environment variable over the package root version
#753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
fix-release-option-set-precedence-order
branch
from
0f391d3
to
5ea96fe
Compare
Jean85
reviewed
Aug 21, 2023
There was a problem hiding this comment.
This env behavior was already documented like this, so I would consider it as a bugfix. But, this wasn't working because the bundle is overriding the default SDK behavior here: https://github.com/getsentry/sentry-php/blob/95d3d3a518010299fc928609ddb05f0067f0b6ac/src/Options.php#L906C1-L906C61
IMHO we should just reverse the priority, and it seems that this PR is doing that... I have a doubt though...
Jean85
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #623. Since the default value for the
releaseoption is hardcoded to be the root package version, theSENTRY_RELEASEenvironment variable is never considered unless explicitly referenced in the config by the user. With these changes, the environment variable is used as default value. If its value is an empty string or the variable is not set, the root package version is used as a fallback.This is technically speaking a change in the behaviour of the config, so it may be worth to document it. However, this may be considered a bugfix rather than an improvement since it was never intended to prefer the root package version over the environment variable.