Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ignore_exceptions and ignore_transactions options to Configurator #724

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Adds ignore_exceptions and ignore_transactions options to Configurator #724

merged 2 commits into from
Jun 23, 2023

Conversation

gassan
Copy link
Contributor

@gassan gassan commented Jun 12, 2023

fixes: #710

@cleptric
Copy link
Member

In order to move this forward, you'll have to update all tests concerning the newly added options.

@gassan
Copy link
Contributor Author

gassan commented Jun 12, 2023

Has someone fixed an Error while testing on End2EndTest-php:

PHP: syntax error, unexpected '=' in Unknown on line 24

@gassan
Copy link
Contributor Author

gassan commented Jun 22, 2023 •
edited
Loading

Tests added. Please fill free to review if needed.

cleptric
cleptric approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cleptric cleptric merged commit d7fe638 into getsentry:master Jun 23, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric approved these changes

Assignees
No one assigned
Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-map ignore_exceptions, add ignore_transactions
2 participants
@gassan @cleptric