Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set cache keys as span descriptions #677

Merged
merged 6 commits into from
May 2, 2023
Merged

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Nov 21, 2022

When possible, set the cache key as the span description when tracing the Symfony cache.

closes #619

@cleptric cleptric linked an issue Nov 21, 2022 that may be closed by this pull request
@cleptric cleptric modified the milestones: 4.5.0, 4.6.0 Nov 28, 2022
Base automatically changed from develop to master February 14, 2023 15:52
@cleptric cleptric modified the milestones: 4.6.0, 4.7.0 Feb 20, 2023
@michaelzangerle
Copy link
Contributor

Hey @cleptric. I stumbled upon the linked issue and your proposed solution looks nice. Any chance this gets merged soon?

@cleptric
Copy link
Member Author

@michaelzangerle Would you mind trying it in one of your apps and reporting back?

@michaelzangerle
Copy link
Contributor

@cleptric I just gave it a try and it already looks so much better and clearer in Sentry especially if you have very long list of cache get / save calls.

  • Seeing CLASSMETADATA helps a lot
  • I guess things like this rApp.Workflow.Config.Message.Response.WorkflowConfigResponse..id are related to the serializer and I have a lot of those in my traces (maybe there is a way to limit this)
  • The only place where it still shows the span id seems to be when cache.save is called

image

image

@cleptric cleptric marked this pull request as ready for review April 24, 2023 14:38
@cleptric cleptric merged commit c9d2b2c into master May 2, 2023
28 checks passed
@cleptric cleptric deleted the cache-span-descriptions branch May 2, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unusable trace data called in a callback
3 participants