Fix deprecation: PDOStatement::bindParam(): Passing null to $maxLength

[Jeroeny]

PHP version: 8.1.1
doctrine/dbal: 3.2.0
sentry/sentry-symfony: 4.2.5

Deprecated: PDOStatement::bindParam(): Passing null to parameter #4 ($maxLength) of type int is deprecated in ./vendor/doctrine/dbal/src/Driver/PDO/Statement.php on line 83

While it may seem that the deprecation is caused by that Doctrine Statement class, it is in fact caused by passing $length as null to that method which is then passed on the the PDOStatement method call. The fix is done the same way as in Doctrine: https://github.com/doctrine/dbal/blob/3.2.x/src/Driver/PDO/Statement.php#L83

[Jean85]

Code looks fine, can you please add a test and a changelog entry?

[Jeroeny]

@Jean85 I've added a test and changelog line. I couldn't just use a willReturnCallback, because phpunit always passed the variable explicitly as null.

[Jean85]

Code looks fine, but the CI is broken. Please fix the Code Style (make cs will do it for you) and fix the test, it's failing for this error:

PHP Fatal error:  Class Sentry\SentryBundle\Tests\Tracing\Doctrine\DBAL\TestStatement must implement interface Traversable as part of either Iterator or IteratorAggregate in Unknown on line 0```

[ste93cry]

@Jeroeny are you up to finish the PR? Otherwise I would be happy to make the changes needed to merge it on your behalf

[Jeroeny]

@ste93cry Feel free to continue with these changes. I probably won't be able to spend time on it anytime soon.

[github-actions]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[keichinger]

@Jean85 do you have a rough ETA when a new version will be released that contains this PR?

[Jean85]

Release of 4.2.7 is in process: https://github.com/getsentry/sentry-symfony/actions/runs/1865381549

[fbnfgc]

@Jean85 thanks for your work on this issue.

It looks like the 4.2.7 version has not been released yet. Do you need to push the tag manually?

[Jean85]

No, there's just a manual step in the process that requires a Sentry employee approval. It'll be here soon.