Fix decoration of the Doctrine DBAL connection when it implemented the ServerInfoAwareConnection interface
#567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
fix/missing-wrapping-for-server-info-aware-connection
branch
5 times, most recently
from
a1db4ac
to
376a199
Compare
|
@fritzmg would you be so gentle to try this out and see if it works? |
Yes, looks like this fixes the automatic server version detection, as far as I have tested 👍 🙂 |
Jean85
approved these changes
Oct 19, 2021
… the `ServerInfoAwareConnection` interface
ste93cry
force-pushed
the
fix/missing-wrapping-for-server-info-aware-connection
branch
from
376a199
to
5b8ffff
Compare
ste93cry
deleted the
fix/missing-wrapping-for-server-info-aware-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #488 (comment): while instrumenting the Doctrine DBAL connection we weren't mirroring whether the original connection had implemented the
ServerInfoAwareConnectioninterface, causing issues withinstanceofchecks