Add support for symfony 6

[alexander-schranz]

Not sure how the test matrix need to be changed locally tests running when doing:

composer config minimum-stability dev
composer update
vendor/bin/phpunit

Fixes #564

Not sure how to fix the psalm error. Feel free to push into my branch.

[Jean85]

Code LGTM 👍

Can you add a changelog entry?
Also, I would like to add a CI job to test this, but I think we will need to require the newer Symfony version in some special way?

[alexander-schranz]

Also, I would like to add a CI job to test this, but I think we will need to require the newer Symfony version in some special way?

You can test again dev dependencies using before running composer update:

composer config minimum-stability dev

[ste93cry]

@alexander-schranz do you plan to keep working on this? Otherwise, I would be happy to take over your work and finish it

[alexander-schranz]

@ste93cry sorry for the late response. I pushed an update to use a different UserStub, still feel free to take it over as a maintainer you should have permissions to directly push here into my branch.

[Jean85]

Just a small nitpick, the rest LGTM 👍

@ste93cry do we want to wait for the official tag to merge?

[ste93cry]

do we want to wait for the official tag to merge?

I would prefer so, so that we can test the CI on the stable version before merging. It should be a matter of a couple of days, so it doesn't really change anything

[jmsche]

Hi, Symfony 6.0 has been released :)

[ste93cry]

Yup, I'm aware of it. Unfortunately now that we can test the stable version more deprecations than expected popped out, plus some of our dependencies are still not compatible with the 6.x components. I will solve as much problems as I can, but the next release will have to wait a bit more

[Jean85]

Main blocker seems PHP-CS-Fixer/PHP-CS-Fixer#6095; but since it's the CS fixer, we could manually remove it in the main jobs to avoid the failures.

[ste93cry]

Actually we have also some issues with PHPStan, Psalm, and PHP-CS-Fixer is hiding some deprecations/incompatibilities with Symfony 6. I don't want to wait forever, just to be clear, but I don't see any need to rush a release. Upgrading immediatly to something entirely new is discouraged anyway in most environments, so waiting a few days/a week is not that bad after all

[pietereggink]

I see that quality checks currently running under php 8.1? Symfony 6 requires 8.0.2. So those deprecations should be fixed in php 8.1 but from my point of view this should be done in a separate pull request right?

[ste93cry]

Just a quick update: PHP-CS-Fixer merged the support for PHP 8.1 and Symfony 6.x, therefore I expect a release shortly. On top of this, we're hitting a bug in the lowest version we require of PHPUnit while mocking methods using nullable union types and I'm understanding if we can get a patch version for it. If not, I will simply do some magic trick in the CI to raise the minimum version for the impacted cases so that next week we can release this package. Thank you all for understanding