Fix missing instrumentation of the Statement::execute()
method of Doctrine DBAL
#548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544: thanks to @jokaorgua I found out that the
Doctrine\DBAL\Driver\Statement::execute()
method has to be instrumented as well for the tracing of SQL queries to work properly in case a prepared statement is used, e.g. when calling theDoctrine\DBAL\Connection::fetch*()
methods and passing some query params to them. I voluntarily avoided a child span for theTracingStatement::execute()
method because you may prepare a query and run it later, so it doesn't make sense to have it nested into the one of theTracingDriverConnection::prepare()
method as it would have happened by creating it inside the callback of theTracingDriverConnection::traceFunction()
function