Exception-based context #491
Conversation
nateberkopec
force-pushed
the
exception-context
branch
from
5279283
to
791a7c7
Compare
|
|
||
| private | ||
|
|
||
| def get_exception_context(exc) |
There was a problem hiding this comment.
hard to see in this diff, but here's the new important method
|
Gonna add docs, fix the build, then I think this is good to go. |
|
We want to use annotate_exception and it seems this patch fixes a bug we've found (the need for the DeepMerge there). Without the deep merge, extra data we pass to annotate exception will be overwritten by the options passed to Event.from_exception. Any plans on getting this merged? |
|
Yes - it'll be in this week, I promise! |
|
@nateberkopec hey, sorry to push you, but I took liberty to look at the tests and it seems the needed changes are merely style. Would it be possible to release it any time soon? |
nateberkopec
force-pushed
the
exception-context
branch
from
791a7c7
to
b98ec40
Compare
|
@nateberkopec awesome! thanks! Will you release a new version? |
|
@juanibiapina yup, doing more work today and then its probably new version time |
|
@nateberkopec Would you release a version with these changes if your current work is not yet finished? |
Closes getsentry#491, references getsentry#182 [ci skip]
Re: #479