Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic graphql tracing with a new :graphql patch #2308

Merged
merged 1 commit into from
May 7, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented May 7, 2024

closes #2091

@sl0thentr0py sl0thentr0py requested a review from st0012 May 7, 2024 09:56
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 98.66%. Comparing base (d0c9897) to head (7f8dcdd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2308      +/-   ##
==========================================
- Coverage   98.73%   98.66%   -0.08%     
==========================================
  Files         203      205       +2     
  Lines       13282    13329      +47     
==========================================
+ Hits        13114    13151      +37     
- Misses        168      178      +10     
Components Coverage Δ
sentry-ruby 99.03% <80.85%> (-0.09%) ⬇️
sentry-rails 97.37% <ø> (ø)
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 96.76% <ø> (-0.33%) ⬇️
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.60% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/graphql.rb 75.00% <75.00%> (ø)
sentry-ruby/spec/sentry/graphql_spec.rb 80.95% <80.95%> (ø)

... and 3 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/graphql-auto branch 2 times, most recently from cb07816 to 324ce45 Compare May 7, 2024 14:17
@sl0thentr0py
Copy link
Member Author

ignore the coverage report here because the uncovered lines are covered in older ruby versions which don't report their coverage

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we should consider requiring a higher version of graphql since there seems to have been a bug that was fixed in v2.2.8?

@sl0thentr0py
Copy link
Member Author

the gem requirement is just for testing, we only have the error message for better DX

@sl0thentr0py sl0thentr0py merged commit b3853e5 into master May 7, 2024
122 of 124 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/graphql-auto branch May 7, 2024 15:16
@adinauer
Copy link
Member

adinauer commented May 7, 2024

I assume it won't explode if set_transaction_name isn't a known param yet for old versions, right? Seems to have been added in https://github.com/rmosolgo/graphql-ruby/pull/4853/files which was released in v2.2.11.

@sl0thentr0py
Copy link
Member Author

yes its a keyword arg so its safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry support for GraphQL-Ruby
2 participants