Remove is_json for envelope and use string check

sentry-ruby/lib/sentry/envelope.rb

@@ -7,20 +7,19 @@ class Item
  STACKTRACE_FRAME_LIMIT_ON_OVERSIZED_PAYLOAD = 500
  MAX_SERIALIZED_PAYLOAD_SIZE = 1024 * 1000
 
- attr_accessor :headers, :payload, :is_json
+ attr_accessor :headers, :payload
 
- def initialize(headers, payload, is_json: true)
+ def initialize(headers, payload)
  @headers = headers
  @payload = payload
- @is_json = is_json
  end
 
  def type
  @headers[:type] || 'event'
  end
 
  def to_s
- [JSON.generate(@headers), @is_json ? JSON.generate(@payload) : @payload].join("\n")
+ [JSON.generate(@headers), @payload.is_a?(String) ? @payload : JSON.generate(@payload)].join("\n")
  end
 
  def serialize
@@ -79,8 +78,8 @@ def initialize(headers = {})
  @items = []
  end
 
- def add_item(headers, payload, is_json: true)
- @items << Item.new(headers, payload, is_json: is_json)
+ def add_item(headers, payload)
+ @items << Item.new(headers, payload)
  end
 
  def item_types

sentry-ruby/lib/sentry/metrics/aggregator.rb

@@ -78,8 +78,7 @@ def flush(force: false)
  envelope = Envelope.new
  envelope.add_item(
  { type: 'statsd', length: payload.bytesize },
- payload,
- is_json: false
+ payload
  )
 
  Sentry.background_worker.perform do

sentry-ruby/spec/sentry/metrics/aggregator_spec.rb

@@ -241,7 +241,6 @@
 
  item = envelope.items.first
  expect(item.headers).to eq({ type: 'statsd', length: item.payload.bytesize })
- expect(item.is_json).to eq(false)
 
  incr, dist = item.payload.split("\n")
  expect(incr).to eq("incr@none:10.0|c|#environment:test,release:test-release|T#{fake_time.to_i - 3}")
@@ -270,7 +269,6 @@
 
  item = envelope.items.first
  expect(item.headers).to eq({ type: 'statsd', length: item.payload.bytesize })
- expect(item.is_json).to eq(false)
 
  incr1, dist1, incr2, dist2 = item.payload.split("\n")
  expect(incr1).to eq("incr@none:10.0|c|#environment:test,release:test-release|T#{fake_time.to_i - 3}")

sentry-ruby/spec/sentry/transport_spec.rb

@@ -188,8 +188,7 @@
  envelope = Sentry::Envelope.new
  envelope.add_item(
  { type: 'statsd', length: payload.bytesize },
- payload,
- is_json: false
+ payload
  )
  envelope
  end