Apply bundler-cache to CI's Ruby setup #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
487fd88
to
0468308
Compare
| ruby-version: ${{ matrix.ruby_version }} | ||
| bundler: "2.3" | ||
| - name: Set up Ruby ${{ matrix.ruby_version }} | ||
| uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| sudo apt-get update | ||
| sudo apt-get install libsqlite3-dev imagemagick | ||
| - name: Set up Ruby ${{ matrix.ruby_version }} | ||
| uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| bundler: "2.3" | ||
| - uses: actions/checkout@v1 | ||
| - name: Set up Ruby ${{ matrix.ruby_version }} | ||
| uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| with: | ||
| redis-version: 5 | ||
| - name: Start Redis | ||
| uses: supercharge/[email protected] |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| ruby-version: ${{ matrix.ruby_version }} | ||
| bundler: "2.3" | ||
| - name: Set up Ruby ${{ matrix.ruby_version }} | ||
| uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| with: | ||
| redis-version: ${{ matrix.sidekiq_version == '7.0' && 6 || 5 }} | ||
| - name: Start Redis | ||
| uses: supercharge/[email protected] |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2204 +/- ##
==========================================
- Coverage 97.41% 97.34% -0.07%
==========================================
Files 97 100 +3
Lines 3671 3734 +63
==========================================
+ Hits 3576 3635 +59
- Misses 95 99 +4
|
0468308
to
8b18a8a
Compare
| ruby-version: ${{ matrix.ruby_version }} | ||
| bundler: "2.3" | ||
| - name: Set up Ruby ${{ matrix.ruby_version }} | ||
| uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
|
I think danger is failing for an unrelated reason: |
|
danger is failing because it wants you to pin the SHA for github actions, we can ignore that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundler-cacheshould automatically pick the right bundler version for us.I also applied prettier formatting to the files as I do think it improves readability.
#skip-changelog