Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tracing Span's op names #1923

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Update Tracing Span's op names #1923

merged 6 commits into from
Oct 31, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Oct 23, 2022

Closes #1903

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Base: 98.46% // Head: 98.45% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c9a2282) compared to base (3097c49).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files         151      151              
  Lines        9258     9267       +9     
==========================================
+ Hits         9116     9124       +8     
- Misses        142      143       +1     
Impacted Files Coverage Δ
...entry-rails/spec/sentry/rails/action_cable_spec.rb 100.00% <ø> (ø)
...y-ruby/spec/sentry/breadcrumb/redis_logger_spec.rb 100.00% <ø> (ø)
...ry/rails/tracing/active_storage_subscriber_spec.rb 92.30% <50.00%> (ø)
...entry-delayed_job/lib/sentry/delayed_job/plugin.rb 100.00% <100.00%> (ø)
sentry-delayed_job/spec/sentry/delayed_job_spec.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/action_cable.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <100.00%> (ø)
...entry-rails/lib/sentry/rails/capture_exceptions.rb 100.00% <100.00%> (ø)
...ntry/rails/tracing/action_controller_subscriber.rb 100.00% <100.00%> (ø)
.../sentry/rails/tracing/active_storage_subscriber.rb 100.00% <100.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012
Copy link
Collaborator Author

st0012 commented Oct 23, 2022

@sl0thentr0py I find it hard to categorize the change 🤔
Ideally matching the convention should give the users better span grouping...etc. on the Sentry side? I believe that's the goal but I'm not sure if that's been implemented. So this may be fit for enhancement?
But on the other hand, if users use span for filtering, this may break that. So it may be a breaking change too.

@sl0thentr0py
Copy link
Member

@st0012 @AbhiPrasad I think we decided to bite the bullet and just make it very clear in the changelogs that some dashboards might break and to migrate them over. We also collected some data and it didn't seem like there were a lot of users affected in general.

So we won't categorize this as a 'breaking' change in traditional terms but just add a clear changelog. Does that sound fine?

@st0012 st0012 marked this pull request as ready for review October 31, 2022 11:42
@st0012 st0012 merged commit 69073ab into master Oct 31, 2022
5.x automation moved this from In progress to Done Oct 31, 2022
@st0012 st0012 deleted the fix-#1903 branch October 31, 2022 16:53
@@ -17,7 +17,7 @@ def collect_exception(env)
end

def transaction_op
"rails.request".freeze
"http.server".freeze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change? Made us reach the transaction limit 💸

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

Align Span Operations
6 participants