-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tracing Span's op names #1923
Conversation
Codecov ReportBase: 98.46% // Head: 98.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
- Coverage 98.46% 98.45% -0.01%
==========================================
Files 151 151
Lines 9258 9267 +9
==========================================
+ Hits 9116 9124 +8
- Misses 142 143 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@sl0thentr0py I find it hard to categorize the change 🤔 |
@st0012 @AbhiPrasad I think we decided to bite the bullet and just make it very clear in the changelogs that some dashboards might break and to migrate them over. We also collected some data and it didn't seem like there were a lot of users affected in general. So we won't categorize this as a 'breaking' change in traditional terms but just add a clear changelog. Does that sound fine? |
@@ -17,7 +17,7 @@ def collect_exception(env) | |||
end | |||
|
|||
def transaction_op | |||
"rails.request".freeze | |||
"http.server".freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change? Made us reach the transaction limit 💸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here...
Closes #1903