Make sure test helper clears the current scope before/after a test #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.40% // Head: 98.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 98.40% 98.41% +0.01%
==========================================
Files 148 148
Lines 8891 8897 +6
==========================================
+ Hits 8749 8756 +7
+ Misses 142 141 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Because the `setup_sentry_test` helper provides a clean client, the scope should be clean too. I also imagine `teardown_sentry_test` includes clearing the current scope's contextual data. And because there's not a `bind_client` equivalent API for scope, we clear the scope's value with `Scope#clear` instead of creating a new scope. But in practice that both of them should work the same.
sl0thentr0py
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
setup_sentry_testhelper provides a clean client, the scope should be clean too. I also imagineteardown_sentry_testincludes clearing the current scope's contextual data.And because there's not a
bind_clientequivalent API for scope, we clear the scope's value withScope#clearinstead of creating a new scope. But in practice that both of them should work the same.