Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request env to rails middleware #1792

Merged

Conversation

linhmtran168
Copy link
Contributor

Description

@st0012 st0012 added this to In progress in 5.x via automation Apr 13, 2022
@st0012 st0012 added this to the 5.3.0 milestone Apr 13, 2022
@st0012
Copy link
Collaborator

st0012 commented Apr 13, 2022

@linhmtran168 Thanks for catching this. I actually consider it a bug fix instead of a feature 🙂 Would you mind also adding a changelog entry? Thx

@linhmtran168
Copy link
Contributor Author

@st0012 I added the changelog entry 😄

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #1792 (403860f) into master (9f6ab0c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         145      145              
  Lines        8559     8576      +17     
==========================================
+ Hits         8424     8440      +16     
- Misses        135      136       +1     
Impacted Files Coverage Δ
...entry-rails/lib/sentry/rails/capture_exceptions.rb 96.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/tracing_spec.rb 99.27% <100.00%> (+0.10%) ⬆️
sentry-resque/lib/sentry/resque.rb 97.14% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6ab0c...403860f. Read the comment docs.

@st0012
Copy link
Collaborator

st0012 commented Apr 17, 2022

@linhmtran168 Thank you 👍

@st0012 st0012 merged commit 942f645 into getsentry:master Apr 17, 2022
5.x automation moved this from In progress to Done Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

Add request info to custom_sampling_context in Rails middleware
3 participants