Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub header values with invalid encoding #1552

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Scrub header values with invalid encoding #1552

merged 3 commits into from
Aug 27, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 26, 2021

Closes #1551

@st0012 st0012 added this to the 4.7.0 milestone Aug 26, 2021
@st0012 st0012 self-assigned this Aug 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #1552 (16a0713) into master (740ed8c) will increase coverage by 0.36%.
The diff coverage is 100.00%.

❗ Current head 16a0713 differs from pull request most recent head ca6d2fd. Consider uploading reports for the commit ca6d2fd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1552      +/-   ##
==========================================
+ Coverage   97.91%   98.27%   +0.36%     
==========================================
  Files         222      127      -95     
  Lines       10855     7030    -3825     
==========================================
- Hits        10629     6909    -3720     
+ Misses        226      121     -105     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/interfaces/request.rb 95.31% <100.00%> (+0.48%) ⬆️
...y/spec/sentry/interfaces/request_interface_spec.rb 99.18% <100.00%> (+0.04%) ⬆️
sentry-rails/app/jobs/sentry/send_event_job.rb 81.25% <0.00%> (-6.25%) ⬇️
sentry-raven/spec/raven/configuration_spec.rb
...-raven/spec/raven/integrations/rails/event_spec.rb
sentry-raven/lib/raven/processor/sanitizedata.rb
sentry-raven/lib/raven/configuration.rb
sentry-raven/spec/raven/integration_spec.rb
...try-raven/lib/raven/utils/exception_cause_chain.rb
sentry-raven/lib/raven/processor/utf8conversion.rb
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740ed8c...ca6d2fd. Read the comment docs.

@st0012 st0012 changed the title Skip header value with non-convertable encoding Scrub header values with invalid encoding Aug 26, 2021
@st0012 st0012 merged commit b285753 into master Aug 27, 2021
@st0012 st0012 deleted the fix-#1551 branch August 27, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event sending failed: "\xC4" from ASCII-8BIT to UTF-8
2 participants