[v3 Branch Pick] Add some error context in transport_failure_callback #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct docs re: transactions * Updated the client failed_send method to include HTTP error when using transport_failure_callback proc * Updated Readme about transport_failure_callback usage * Fixed conflicts with v3 previous updates * Updated Readme
Codecov Report
@@ Coverage Diff @@
## v3-1 #1003 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 46 46
Lines 2187 2187
=======================================
Hits 2140 2140
Misses 47 47
Continue to review full report at Codecov.
|
st0012
added a commit
that referenced
this pull request
Aug 28, 2020
* Correct docs re: transactions * Updated the client failed_send method to include HTTP error when using transport_failure_callback proc * Updated Readme about transport_failure_callback usage * Fixed conflicts with v3 previous updates * Updated Readme Co-authored-by: Etienne Depaulis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks the changes from #796 with some additional fixes.
Closes #661