runtime-dyno-metadata warning even if SENTRY_DSN is not set

[jonekdahl]

We're using Sentry in our app that runs on Heroku, but we don't install the Sentry add-on for our review apps, so SENTRY_DSN is not set for those apps.

I think I've read somewhere that one way to "deactivate" Sentry is to simply not set SENTRY_DSN, so this should be fine. However, I still get the runtime-dyno-metadata warning:

WARN -- sentry: ** [Raven] You are running on Heroku but haven't enabled Dyno Metadata. For Sentry's release detection to work correctly, please run `heroku labs:enable runtime-dyno-metadata`

I would like Sentry to be completely silent when SENTRY_DSN is not available, or at least not log warnings.

[SampsonCrowley]

It would also be nice not to get this warning when the version is already explicitly set

[jonekdahl]

It looks like similar issues were have been raised before (#755, #864) but so far there is no solution apart from enabling Dyno Metadata, which is tricky for review apps since Heroku labs features cannot be added through app.json.

[st0012]

@jonekdahl what environment will the review app have? will it be production too or something like review or staging?

[jonekdahl]

@st0012 Are you asking about RAILS_ENV? I don't believe Heroku puts any restrictions on that, so it could be any of the above. We're using 'production'.

[pil0u]

EDIT: it seems that it was just a lag on Heroku's side. Redepolying without the variable worked.

I am not sure if it's the right place to ask but on the very bottom of this page from the docs, it says:

With Sentry, you may either set the SENTRY_DSN environment variable (recommended), or set your DSN manually in a config block

When my config.dns is set in my Rails app and I properly ran the heroku labs:enable runtime-dyno-metadata -a <app_name> command, I still get the warning mentioned in this issue.
If on top of that, I set the SENTRY_DSN variable in my Heroku variables, the warning disappears.

From the documentation, I thought that one solution or the other should work. Should I open another issue for that matter?

[st0012]

hey sorry for the long delay 🙏 I have fixed this in #1471 and it will be included in the next patch release.
(because sentry-raven has entered maintenance mode, the fix will not be backported there. you can follow the migration guide to migrate to the new SDK 🙂)