fix: Update protocol version to 7 #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhcarvalho thanks for catching this. can you also add a changelog entry for it? |
|
@rhcarvalho looks like the tests are failing. I'll take care of this if you don't mind? |
Yes, please do take over, I'd appreciate your help with tests+changelog 👍 |
Modern SDKs use protocol version 7. The version triggers different code paths during ingestion, and so the modern Ruby SDK should also use v7.
st0012
force-pushed
the
rhcarvalho/proto-v7
branch
from
98dd4b9
to
54bdba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern SDKs use protocol version 7.
The version triggers different code paths during ingestion, and so the modern Ruby SDK should also use v7.
See https://develop.sentry.dev/sdk/overview/#authentication.
Fixes #867