Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change protocol version to 7 #867

Closed
nateberkopec opened this issue Sep 27, 2018 · 3 comments · Fixed by #1434
Closed

Change protocol version to 7 #867

nateberkopec opened this issue Sep 27, 2018 · 3 comments · Fixed by #1434

Comments

@nateberkopec
Copy link
Contributor

No description provided.

@st0012 st0012 added this to Needs triage in 3.x Aug 28, 2020
@st0012 st0012 removed this from Needs triage in 3.x Apr 11, 2021
@st0012
Copy link
Collaborator

st0012 commented Apr 11, 2021

The protocol is barely used and basically irrelevant right now. So the change won't be necessary.

@st0012 st0012 closed this as completed Apr 11, 2021
@rhcarvalho
Copy link
Contributor

I've just noticed this in code, was going to open an issue then found this.
Need to check with the rest of the team what the version is used for, but we should probably be reporting something consistent if we want to ever be able to enforce versioning. For instance, the server could ignore datatypes non-existing in version 5 (for example transactions).

@rhcarvalho
Copy link
Contributor

Talked with the rest of the SDK team. Heard that the ingestion pipeline goes through different code paths depending on version, so considering all modern SDKs are on v7, we should update the Ruby SDK to use 7 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants