-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't read in entire request body #706
Comments
Code has been moved around since the above was written, but I think it linked to this line: https://github.com/getsentry/raven-ruby/blob/884998d35edeed29d4fe49519d611d56936058a7/lib/raven/integrations/rack.rb#L85 |
Adding a bug label because this can also cause events to be rejected for being too large. |
@nateberkopec I'm wondering if the request can't be streamed? |
* use ! to ensure exception gets raised * remove need for ! * Update sentry raven version to resolve bug getsentry/sentry-ruby#706
This is not good: https://github.com/getsentry/raven-ruby/blob/master/lib/raven/integrations/rack.rb#L85 and will be very slow if the request body is large.
Also we will probably remove it from the event anyway.
The text was updated successfully, but these errors were encountered: