Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read in entire request body #706

Closed
nateberkopec opened this issue Jul 7, 2017 · 4 comments
Closed

Don't read in entire request body #706

nateberkopec opened this issue Jul 7, 2017 · 4 comments

Comments

@nateberkopec
Copy link
Contributor

This is not good: https://github.com/getsentry/raven-ruby/blob/master/lib/raven/integrations/rack.rb#L85 and will be very slow if the request body is large.

Also we will probably remove it from the event anyway.

@dentarg
Copy link
Contributor

dentarg commented Sep 28, 2017

This is not good: https://github.com/getsentry/raven-ruby/blob/master/lib/raven/integrations/rack.rb#L85 and will be very slow if the request body is large.

Code has been moved around since the above was written, but I think it linked to this line: https://github.com/getsentry/raven-ruby/blob/884998d35edeed29d4fe49519d611d56936058a7/lib/raven/integrations/rack.rb#L85

@nateberkopec
Copy link
Contributor Author

Adding a bug label because this can also cause events to be rejected for being too large.

@Davidslv
Copy link

Davidslv commented Jun 1, 2018

@nateberkopec I'm wondering if the request can't be streamed?

damienh added a commit to NCCE/teachcomputing.org that referenced this issue Mar 10, 2020
damienh added a commit to NCCE/teachcomputing.org that referenced this issue Mar 10, 2020
* use ! to ensure exception gets raised

* remove need for !

* Update sentry raven version to resolve bug

getsentry/sentry-ruby#706
@st0012 st0012 modified the milestones: 3.0.0, 3.0.1 Aug 6, 2020
@st0012 st0012 modified the milestones: 3.0.1, 3.1.0 Aug 14, 2020
@st0012 st0012 added this to Needs triage in 3.x via automation Aug 14, 2020
@st0012 st0012 modified the milestones: 3.1.0, 4.0.0 Aug 28, 2020
@st0012 st0012 added this to To do in 4.x via automation Aug 28, 2020
@st0012 st0012 removed this from Needs triage in 3.x Aug 28, 2020
@st0012 st0012 modified the milestones: 4.0.0, 4.1.0, 4.2.0 Dec 10, 2020
@st0012 st0012 modified the milestones: 4.2.0, 4.3.0 Jan 27, 2021
@st0012 st0012 removed this from the 4.3.0 milestone Mar 2, 2021
@st0012
Copy link
Collaborator

st0012 commented Jul 1, 2021

I think this is not an issue anymore. Sentry now trims long data on the server side instead of rejecting the event.

截圖 2021-07-01 下午5 35 50

@st0012 st0012 closed this as completed Jul 1, 2021
4.x automation moved this from To do to Done Jul 1, 2021
@st0012 st0012 removed this from Done in 4.x Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants