Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to mute transaction spans in a block #1943

Closed
booleanbetrayal opened this issue Nov 21, 2022 · 3 comments
Closed

Ability to mute transaction spans in a block #1943

booleanbetrayal opened this issue Nov 21, 2022 · 3 comments
Assignees

Comments

@booleanbetrayal
Copy link

Describe the idea

Skylight has Skylight.mute support to selectively disable span construction in a block, during operations known to inflate payload sizes unnecessarily or for any reason a developer might not be interested in that information. I haven't found any sort of corresponding support in Sentry, which is causing us troubles with payload contraints. Likewise, because there is no ability to interact with the transaction like before_send, we are at a loss for how to deal with this situation.

Why do you think it's beneficial to most of the users

Users will likely have requirements where selective disabling of span recording could allow transactions to succeed / be more contextually relevant, where they were not before.

Possible implementation

Sentry.mute method that behaves identically to Skylight.mute.

@sl0thentr0py
Copy link
Member

thx @booleanbetrayal I'll discuss this internally and get back to you. Ideally when we implement high level features such as these, we should do them across all languages.

@booleanbetrayal
Copy link
Author

Thank you @sl0thentr0py . Feel free to reach out if you need any use-case specifics.

@sl0thentr0py
Copy link
Member

we're going to eventually move to opentelemetry like api's anyway so for this is out of the picture for now, closing.

@sl0thentr0py sl0thentr0py closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants