Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span truncation #1845

Open
sl0thentr0py opened this issue Jul 13, 2022 · 5 comments
Open

Span truncation #1845

sl0thentr0py opened this issue Jul 13, 2022 · 5 comments
Assignees

Comments

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Jul 13, 2022

Add some span truncation logic similar to frames/breadcrumbs

@Linuus
Copy link

Linuus commented Oct 14, 2022

Would this solve the issue we have where our most important events are being dropped? (I've been asking about this in the Discord channel since this summer).

For instance, let's say we have a background job which is doing some work (enqueueing other jobs, making HTTP calls etc). Sometimes they take a long time and can't see those performance traces because they are being dropped (I think). Now, the performance traces in Sentry all look fast and fine, but the really interesting ones that I want to debug aren't in there at all, which makes it a bit pointless :(

So, I'd be a very happy customer whenever this is implemented 🙏

@smeubank
Copy link
Member

@sl0thentr0py by truncation is it temporal cut or content of span.

@Linuus would be interested to know if you can tell us the reason why & when your spans are being dropped?

@bmulholland
Copy link

bmulholland commented Oct 14, 2022

I’ve experienced dropped spans transactions with long-running http requests before. The request took more than a few seconds, and I guess was then too big to come through. I verified this with support, who pointed me to this issue. #70304

@Linuus
Copy link

Linuus commented Oct 14, 2022

@Linuus would be interested to know if you can tell us the reason why & when your spans are being dropped?

it’s not spans that are dropped. It’s the entire event. I can’t see performance traces for these at all.

For instance, we have a background job which is enqueueing a couple of thousand other jobs. Each of those enqueues gets a span (activejob.enqueue_at or something). With all those spans the payload gets too big and it’s all dropped.

@booleanbetrayal
Copy link

We are also curious about this. We are logging oversized transactions in which spans contains large blocks of SQL that should possibly be truncated in some fashion. As it stands, our most SQL-verbose transactions appear to be getting dropped due to payload sizing constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants