Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(performance): add more debug logs to native frames integration #3880

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • Enhancement
  • Refactoring

📜 Description

This PR adds more logs to the Native Frames integration to make is easier to undestand why the SDK is not adding native frames measurements to the transaction.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 489.29 ms 524.44 ms 35.15 ms
Size 17.73 MiB 19.94 MiB 2.21 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms
abb7058 370.27 ms 389.58 ms 19.31 ms

App size

Revision Plain With Sentry Diff
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit f2f3399 into main Jun 13, 2024
58 of 61 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/fix-native-frames-logs branch June 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants