Skip to content

Commit

Permalink
fix(CONTRIBUTION.md): Fix iOS guide, dependency on Sentry is required (
Browse files Browse the repository at this point in the history
  • Loading branch information
krystofwoldrich committed Jun 4, 2024
1 parent 202f386 commit ee8e7fc
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ Comment out sentry dependency in `RNSentry.podspec`.

```diff
- s.dependency 'Sentry/HybridSDK', '7.31.0'
+ # s.dependency 'Sentry/HybridSDK', '7.31.0'
+ s.dependency 'Sentry/HybridSDK'
```

Add local pods to `sample/ios/Podfile`.
Expand All @@ -123,9 +123,7 @@ target 'sample' do

# ... react native config

+ pod 'Sentry/HybridSDK', :path => '../../../sentry-cocoa'
+ pod 'SentryPrivate', :path => '../../../sentry-cocoa/SentryPrivate.podspec'

pod 'Sentry/HybridSDK', :path => '../../../../sentry-cocoa'
# ... rest of the configuration

end
Expand All @@ -151,12 +149,12 @@ cd sentry-react-native/sample

Add local maven to `sample/android/build.gradle`.

```diff
+ allprojects {
+ repositories {
+ mavenLocal()
+ }
+ }
```gradle
allprojects {
repositories {
mavenLocal()
}
}
```

Update `sentry-android` version, to the one locally published, in `android/build.gradle`.
Expand Down

0 comments on commit ee8e7fc

Please sign in to comment.