Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation comment for profiler internals #3167

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

sentrivana
Copy link
Contributor

These symbols were never explicitly part of the public API, but they were also not explicitly marked as private, so out of abundance of caution we kept them around as importable straight from sentry_sdk.profiler when reorganizing modules in the scope of #2830. However, since they were never meant to be public, we want to remove them from the implicitly public API, so we deprecate them here.

This also needs to be called out in the changelog.

@sentrivana sentrivana enabled auto-merge (squash) June 13, 2024 14:08
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@sentrivana sentrivana merged commit 0878593 into master Jun 13, 2024
111 checks passed
@sentrivana sentrivana deleted the ivana/deprecate-profiler-interface branch June 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants