Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Move thread data to trace context #3157

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

Zylphrex
Copy link
Member

The thread data was added to the profile context in #2830. It should live in the trace context to align with other SDKs.


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

The thread data was added to the profile context in #2830. It should live in the
trace context to align with other SDKs.
@sentrivana sentrivana merged commit a6c03a9 into master Jun 12, 2024
111 checks passed
@sentrivana sentrivana deleted the txiao/fix/move-thread-data-to-trace-context branch June 12, 2024 07:52
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
The thread data was added to the profile context in getsentry#2830. It should live in the
trace context to align with other SDKs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants