Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log internal debug and error messages to a PSR-3 compatible logger #989

Merged
merged 4 commits into from
Mar 23, 2020

Conversation

ste93cry
Copy link
Collaborator

Q A
Branch? 2.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Starting from the work done in #907, I've added support for logging some debug and error messages to a PSR-3 compatible logger. In the future we may want to log additional info, for example when we will implement rate limit handling for the HttpTransport transport

composer.json Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
src/Integration/Handler.php Show resolved Hide resolved
src/Transport/DefaultTransportFactory.php Show resolved Hide resolved
src/Transport/HttpTransport.php Outdated Show resolved Hide resolved
src/Transport/HttpTransport.php Outdated Show resolved Hide resolved
@ste93cry ste93cry force-pushed the feature/psr3-logger-support branch from 88dbf1b to 7038653 Compare March 16, 2020 23:50
@ste93cry ste93cry requested a review from Jean85 March 16, 2020 23:58
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nitpick, LGTM for the rest

tests/ClientTest.php Outdated Show resolved Hide resolved
tests/ClientTest.php Show resolved Hide resolved
@ste93cry ste93cry requested a review from Jean85 March 17, 2020 19:13
@ste93cry ste93cry force-pushed the feature/psr3-logger-support branch from 447f508 to 17bfcc3 Compare March 17, 2020 19:33
@ste93cry ste93cry force-pushed the feature/psr3-logger-support branch from 9535ad3 to 9e3aeb2 Compare March 23, 2020 00:45
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (even a changelog 💪)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants