Make the integrations option accept a callable
#919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
Nov 6, 2019
…e list of default integrations and returns a custom list
ste93cry
force-pushed
the
feature/integrations-option-as-lambda
branch
from
c00f448
to
e680e02
Compare
ste93cry
force-pushed
the
feature/integrations-option-as-lambda
branch
from
e680e02
to
5769581
Compare
Jean85
requested changes
Nov 11, 2019
ste93cry
force-pushed
the
feature/integrations-option-as-lambda
branch
from
d0dede3
to
9a17212
Compare
stayallive
requested changes
Nov 25, 2019
Jean85
approved these changes
Nov 26, 2019
|
Can we please remember to do a PR to the docs once this is released? |
This was referenced Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the SDK behavior of the
integrationsoption with the one present in the JS SDK. Basically, instead of accepting only a list of integrations, acallablecan now be set that will receive the list of default integrations and will return a (customized) list of integrations. This allows users to pick only certain default integrations without having to maintain in their own project the list of default integrations that must be kept in sync with the one of our library