Add a processor to sanitize the HTTP headers #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
feature/sanitize-http-headers-processor
branch
2 times, most recently
from
384d630
to
d3e3f1b
Compare
|
Any reason you wouldn't use processorOptions for this? |
|
The reason is that the code is a porting from the Ruby processor where the options were specified directly in the configuration of the client. If you want (I absolutely agree on this) I can change the code to use that method instead. |
|
sorry for delay -- most of our SDKs aren't fully in sync with non-standard configuration, so I'd prefer we use processorOptions here |
ste93cry
force-pushed
the
feature/sanitize-http-headers-processor
branch
from
d3e3f1b
to
e49ffe9
Compare
ste93cry
force-pushed
the
feature/sanitize-http-headers-processor
branch
from
e49ffe9
to
a9b5cd2
Compare
|
I fixed everything as requested, PR is ready for review and merge |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some HTTP headers like the
Authorizationheader could contain sensitive informations. The processor added with this PR is a porting of the one added for the Ruby client in getsentry/sentry-ruby#537