feat(tracing): create spans for all click events #9002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
DominikB2014
commented
Sep 21, 2023
| @@ -26,7 +26,7 @@ const BUNDLE_VARIANTS = ['.js', '.min.js', '.debug.min.js']; | |||
| export function makeBaseBundleConfig(options) { | |||
| const { bundleType, entrypoints, jsVersion, licenseTitle, outputFileBase, packageSpecificConfig } = options; | |||
|
|
|||
| const isEs5 = jsVersion.toLowerCase() === 'es5'; | |||
| const isEs5 = jsVersion && jsVersion.toLowerCase() === 'es5'; | |||
There was a problem hiding this comment.
I had some compliation errors without this 🤷
I can delete if we want, but i don't see any harm in keeping it.
DominikB2014
force-pushed
the
DominikB2014/correct-span-op
branch
from
84b4d22
to
fd5c666
Compare
This reverts commit fd5c666.
DominikB2014
commented
Sep 21, 2023
Comment on lines
+419
to
+424
| inflightInteractionTransaction.startChild({ | ||
| description: htmlTreeAsString(target), | ||
| op, | ||
| startTimestamp: timestampInSeconds(), | ||
| endTimestamp: timestampInSeconds() + 0.001, | ||
| }); |
There was a problem hiding this comment.
Ideally we can get the timestamps from performance entries, but for now i'm just marking this in the event handler.
There was a problem hiding this comment.
do we also need to set a finish reason here?
DominikB2014
requested review from
AbhiPrasad,
0Calories and
edwardgou-sentry
DominikB2014
force-pushed
the
DominikB2014/correct-span-op
branch
from
9ef6a03
to
d8c53c3
Compare
edwardgou-sentry
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
I think it lgtm, maybe we can get @AbhiPrasad to take a quick look over the code before me merge?
Comment on lines
+419
to
+424
| inflightInteractionTransaction.startChild({ | ||
| description: htmlTreeAsString(target), | ||
| op, | ||
| startTimestamp: timestampInSeconds(), | ||
| endTimestamp: timestampInSeconds() + 0.001, | ||
| }); |
There was a problem hiding this comment.
do we also need to set a finish reason here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some work towards #getsentry/team-sdks/issues/32
This ensures interaction transactions are created with the appropriate OP for click, mousedown, mouseup, and contextmenu events.
Click - Click events work the same as before, an idle transaction is created in the event handler, and the performance entry for the click will be added as a span if available. The op is
ui.action.left.clickMousedown/mouseup - Mousedown will start a regular transaction, a mousedown span is added, the transaction will end when a mouseup occurs and a mouseup span will be added. The op is
ui.action.left.mousedown.Unfortunately the performance entry needs more work to be added here. The performance entry handler fires after the three event handlers, 'mouseup', 'moundown` and 'click' occurs, which is after the mousedown transaction finishes.
Contextmenu (aka right click) - context menu work the same as clicks, an idle transaction is created, the performance entry is added as a span if available. The op is
ui.action.right.contextmenu. Handling mouseup/mousedown for right click is a bit more involved, so i didn't handle it here.This seems to work well with the demo app i've created, but i'm going to leave this as draft until I test it a bit more. Early feedback is encouraged! If this is good behaviour for transaction creation, then getting better spans and grouping interaction is a good next step!