Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox source url fix #20

Merged
merged 3 commits into from
Sep 11, 2012
Merged

Conversation

zimbatm
Copy link

@zimbatm zimbatm commented Aug 22, 2012

Report correct origin url in FF

@bkonkle
Copy link
Contributor

bkonkle commented Sep 4, 2012

I put testMode in because there are issues with Raven.getHeaders on local files. I believe it's needed for some browsers in order for the tests to run. I'll double check that. The rest of this change looks great, though. Thank you!

Jonas Pfenniger added 3 commits September 8, 2012 15:52
Fetching HTTP headers on the file:https:/// scheme doesn't work, thus the
testMode. Here we're just being more precise about it.
And potentially other browsers.
@zimbatm
Copy link
Author

zimbatm commented Sep 8, 2012

I see. It must be IE, I couldn't reproduce the error in Chrom/FF/Safari/Opera under OSX. I pushed another change instead that just disables the getHeader function instead of the whole HTTP interface.

@bkonkle
Copy link
Contributor

bkonkle commented Sep 11, 2012

Okay, after some testing in Chrome, Safari, Firefox, Opera, and IE9, here are the quirks:

Firefox, Opera, and IE9 do not support origin, so it should be dropped.

IE9 does not support href.

All 5 support protocol + host + pathname, so that's what I'll move Raven to.

I'll merge this in and tweak the url. Thanks for the contribution!

bkonkle added a commit that referenced this pull request Sep 11, 2012
Make the source url compatible with more browsers, and allow the Http interface in test mode (without getting headers)
@bkonkle bkonkle merged commit 34a8330 into getsentry:develop Sep 11, 2012
kamilogorek pushed a commit that referenced this pull request Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants