Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(types): sentry API supports breadcrumb as string #11082

Closed
wants to merge 1 commit into from

Conversation

cadesalaberry
Copy link
Contributor

@cadesalaberry cadesalaberry commented Mar 13, 2024

Is there a way to backport this change to the 7.x version?

A timestamp representing when the breadcrumb occurred. The format is either a string as defined in RFC 3339 or a numeric (integer or float) value representing the number of seconds that have elapsed since the Unixepoch.
Breadcrumbs are most useful when they include a timestamp, as it creates a timeline leading up to an event expection/error.

https://develop.sentry.dev/sdk/event-payloads/breadcrumbs/#:~:text=is%20info.-,timestamp,-(recommended)

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Lint fails on unrelated code:

lerna ERR! yarn run lint exited 1 in '@sentry/wasm'

Tests fails on unrelated code:

@sentry/utils:     src/is.ts:4:45 - error TS2307: Cannot find module '@sentry/types'.

> A timestamp representing when the breadcrumb occurred. The format is either a string as defined in RFC 3339 or a numeric (integer or float) value representing the number of seconds that have elapsed since the Unixepoch.
Breadcrumbs are most useful when they include a timestamp, as it creates a timeline leading up to an event expection/error.

https://develop.sentry.dev/sdk/event-payloads/breadcrumbs/#:~:text=is%20info.-,timestamp,-(recommended)
@cadesalaberry cadesalaberry changed the base branch from 7.x to develop March 15, 2024 08:57
@cadesalaberry cadesalaberry changed the base branch from develop to 7.x March 15, 2024 08:57
@AbhiPrasad
Copy link
Member

I assume this is superceded by #11119?

@mydea
Copy link
Member

mydea commented Jul 2, 2024

Hey, thank you for opening this PR. We will for now not widen the API like this, as it increases bundle size and complexity. We may revisit this in the future. Still, thank you for your contribution - we really appreciate it!

@mydea mydea closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants