feat(astro): add tunnelRoute option (#10309) #10334
Draft
+130
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have something like changesets? Couldn't find it |
|
@florian-lefebvre we handwrite our changelogs since we rely on gitflow + our release tool craft - feel free to open up the PR we'll take care of the changelog! |
|
Hey @florian-lefebvre thanks for opening this PR! I only skimmed it as I don't have much time at the moment but will take a closer look hopefully tomorrow. Nice idea with the virtualized config module! I ran CI and looks like there are some build issues in the Astro package. Are you able to reproduce this locally? |
|
A few reasons, but idk how to fix them:
Regarding testing, there's something about virtual modules (see docs). I've almost never tested Astro/integration code before so I'm not sure what's the best approach here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10309
yarn lint) & (yarn test).I have not added tests just yet because I don't know how to mock virtual imports. I'm waiting for an answer from the Astro Discord.