Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not require options with defaults in Typescript #412

Merged
merged 1 commit into from
Feb 4, 2022
Merged

fix: Do not require options with defaults in Typescript #412

merged 1 commit into from
Feb 4, 2022

Conversation

chetbox
Copy link
Contributor

@chetbox chetbox commented Feb 4, 2022

When initialising with Sentry.init({...}) make options with default optional in Typescript.
i.e. ipcMode and getSessions.

See #370 (comment)

@chetbox
fix: Do not require options with defaults in Typescript
adaab4b 
When initialising with `Sentry.init({...})`
@chetbox chetbox mentioned this pull request Feb 4, 2022
Closed
@timfish timfish self-requested a review February 4, 2022 17:43
@timfish timfish merged commit 1c2598c into getsentry:master Feb 4, 2022
@chetbox chetbox deleted the do-not-require-options-with-defaults branch February 4, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chetbox @timfish