ref: Don't call beforeSend for internal minidump #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
commented
Nov 4, 2020
Comment on lines
+155
to
+158
| { | ||
| data: { | ||
| __sentry__: true, | ||
| }, |
There was a problem hiding this comment.
if an event has this in the hint, we will not invoke beforeSend.
There was a problem hiding this comment.
Do we even need the __INTERNAL_MINIDUMP then?
There was a problem hiding this comment.
Yes we do, this __sentry__ is used internally if our SDK captures something itself.
The __INTERNAL_MINIDUMP, while being a workaround is something else.
|
Posted my comment in #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.